Skip to content

Add aria-busy to AI Song Modal import button#434

Merged
ford442 merged 2 commits intomainfrom
palette-add-aria-busy-ai-song-modal-15545524829121002300
Apr 12, 2026
Merged

Add aria-busy to AI Song Modal import button#434
ford442 merged 2 commits intomainfrom
palette-add-aria-busy-ai-song-modal-15545524829121002300

Conversation

@ford442
Copy link
Copy Markdown
Owner

@ford442 ford442 commented Apr 10, 2026

The "Import Song" button within AISongModal.tsx handles asynchronous song parsing and importing. While it visually indicated its loading state and disabled itself appropriately, it lacked the semantic aria-busy attribute. This change standardises the UX across the repository by explicitly exposing the busy state to assistive technologies, making the application more accessible.

I also added an entry to .Jules/palette.md noting the standardization of aria-busy for background import processes.


PR created automatically by Jules for task 15545524829121002300 started by @ford442

Added the `aria-busy={isImporting}` attribute to the AI Song Modal's "Import Song" button.
This ensures screen readers receive explicit context that a background loading task is occurring, bringing the component in line with the accessibility patterns used in other import modals (e.g., RbsImportModal).

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ford442 ford442 merged commit 8b6e119 into main Apr 12, 2026
1 check passed
@ford442 ford442 deleted the palette-add-aria-busy-ai-song-modal-15545524829121002300 branch April 12, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant